Add IR marking laser for aircraft #7761
Conversation
more details? I would expect delay by a few frames, and then a "instant" flop into position. |
Perhaps make the laser's dot bigger, to create more of an area marking laser, rather than a pinpoint one? |
|
Aircraft don't have weapon attachments... |
|
Here is my script with the hopefully 2.08 scripted lasers feature |
|
The 3den attribute is weird, it's default value is true. I had to set it to false, which added the attribute to the sqm |
|
UAV's hate having this thing attached, they kept going up in altitude to avoid it I forget what I did but somehow I ended up with this "burning" spot left, but it eventaully went away after a few seconds |
Maybe we should wait for 2.08 and use drawLaser? |
Co-authored-by: PabstMirror <[email protected]>
Co-authored-by: PabstMirror <[email protected]>
Co-authored-by: PabstMirror <[email protected]>
How are you testing this? I tried it with the Yabhon drone and a loiter waypoint at 500 m altitude, which seems to work just fine. That was pretty much the use case I had in mind originally. We could switch to the scripted laser later, if that has the same capability (range would be my main concern), but I would prefer not delaying this PR further unless necessary. 2.06 is already taking quite a while, so I don't expect 2.08 to still arrive this year. I've fixed the attribute by enabling the laser by default. The bright spot is odd, since that should be part of the model, which is clearly not visible. I'd assume this is caused by some sort of lazy update within the engine. If you can repro it, please let me know. |
Thats indeed not planned. rather Q1 2022 |
|
Just a reminder that 2.08 already released. |
Because |
There was a problem hiding this comment.
Got loads of
21:49:32 Error in expression <EqualTo [] } do {
_intersects = lineIntersectsSurfaces [_startPos, _endP>
21:49:32 Error position: <lineIntersectsSurfaces [_startPos, _endP>
21:49:32 Error 0 elements provided, 3 expected
21:49:32 File /z/ace/addons/markinglaser/functions/fnc_renderPFH.sqf..., line 357
21:49:32 Error in expression <ivate _elevation = _modelVector#2 atan2 vectorMagnitude [_modelVector # 0, _mode>
21:49:32 Error position: <vectorMagnitude [_modelVector # 0, _mode>
21:49:32 Error Type Any, expected Number
21:49:32 File /z/ace/addons/markinglaser/functions/fnc_renderPFH.sqf..., line 339
being spammed after my plane crashed and I teleported myself out with Zeus (not sure if the teleportation had much of an effect tbh).
| params ["_aircraft"]; | ||
|
|
||
| GVAR(lasers) deleteAt (GVAR(lasers) find _aircraft); | ||
| GVAR(localLasers) deleteAt (GVAR(localLasers) find _laser); |
|
|
||
| GVAR(lasers) pushBack _aircraft; | ||
| if (local _aircraft) then { | ||
| GVAR(localLasers) pushBack _laser; |
| }; | ||
|
|
||
| if (isServer) then { | ||
| _aircraft removeMPEventHandler ["MPKilled", _aircraft getVariable QGVAR(killedEH)]; |
There was a problem hiding this comment.
https://community.bistudio.com/wiki/removeMPEventHandler
Comment is from 2011, but it worries me a little. Imo we'd be safer using extended CBA EH.
| if (didJIP) then { | ||
| { | ||
| if (_x getVariable [QGVAR(laserOn), false]) then { | ||
| [_x] call FUNC(onLaserOn); | ||
| }; | ||
| } forEach (allMissionObjects "Air"); | ||
| }; |
There was a problem hiding this comment.
Why not store all lasers on the server, then send them to connecting clients when requested? See the dogtags component for an implementation.
| // Keybinds | ||
| ["ACE3 Vehicles", QGVAR(toggleLaser), LLSTRING(ToggleLaser), { | ||
| // Ignore when in Zeus | ||
| if (!isNull curatorCamera) exitWith {}; |
There was a problem hiding this comment.
I added this because previously there was nothing, but we might want to add a CBA registered camera check.
| * Public: No | ||
| */ | ||
|
|
||
| if (GVAR(lasers) isEqualTo []) exitWith {}; |
| * Public: No | ||
| */ | ||
|
|
||
| if (GVAR(localLasers) isEqualTo []) exitWith {}; |
|
|
||
| // Start PFHs if this is the first laser | ||
| if (local _aircraft && {GVAR(updatePFH) == -1}) then { | ||
| GVAR(updatePFH) = [LINKFUNC(updatePFH), 1, []] call CBA_fnc_addPerFrameHandler; |
There was a problem hiding this comment.
| GVAR(updatePFH) = [LINKFUNC(updatePFH), 1, []] call CBA_fnc_addPerFrameHandler; | |
| GVAR(updatePFH) = [LINKFUNC(updatePFH), UPDATE_INTERVAL, []] call CBA_fnc_addPerFrameHandler; |
|
Last time I tested this in mp there were big problems with laser position syncing |
When merged this pull request will:
TODO:
Screenshot:
Reference image (the only one I could find, would love to see more if anybody finds some):
Source
Mainly publishing this as a POC for custom IR lasers, I think the concept is pretty neato.